-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit TimeType subtraction #51743
Merged
Merged
limit TimeType subtraction #51743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
approved these changes
Oct 17, 2023
KristofferC
pushed a commit
that referenced
this pull request
Oct 23, 2023
Disallow some type combinations that don't make sense. --------- Co-authored-by: Ben Baumgold <[email protected]> (cherry picked from commit 8a889ff)
Isn't this a bit breaking? From PkgEval on backport branch:
|
JeffBezanson
added a commit
that referenced
this pull request
Oct 26, 2023
Restores the method whose removal was probably causing problems.
JeffBezanson
added a commit
that referenced
this pull request
Oct 26, 2023
Restores the method whose removal was probably causing problems. (cherry picked from commit 14d9c7c)
JeffBezanson
added a commit
that referenced
this pull request
Oct 26, 2023
Restores the method whose removal was probably causing problems.
KristofferC
pushed a commit
that referenced
this pull request
Oct 30, 2023
Restores the method whose removal was probably causing problems. (cherry picked from commit f6f1ee9)
KristofferC
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the plan approved by triage. Replaces #49805.