strings: fix performance of nextind #51671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Oct 11, 2023
The recursion (for invalid bytes) was preventing inlining, as was the length of the function. For ASCII data, the cost of the call far exceeds the cost of decoding the data. Closes #51624
vtjnash
force-pushed
the
jn/fast-nextind
branch
from
48fed49 to
7244a31
Compare
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursion (for invalid bytes) was preventing inlining, as was the length of the function. For ASCII data, the cost of the call far exceeds the cost of decoding the data.
This was harmed by Keno's PR #50805, since we now miscompute the inlining cost of the error branch, though I don't think it worked before either as we still mis-estimated the cost of jl_string_ptr as 20 instead of 1.
Closes #51624
@nanosoldier
runbenchmarks("string" || "strings" || "io", vs=":master")