Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference: better align type_more_complex with _limit_type_size for Type #51600

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 5, 2023

A small further extension to #51512 to better align the internal behavior of the _limit_type_size and type_more_complex computations

@nanosoldier runbenchmarks(!"scalar", vs=":master")

@vtjnash vtjnash added needs nanosoldier run This PR should have benchmarks run on it needs pkgeval Tests for all registered packages should be run with this change labels Oct 5, 2023
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@oscardssmith
Copy link
Member

@nanosoldier runtests()

@oscardssmith oscardssmith removed the needs nanosoldier run This PR should have benchmarks run on it label Oct 6, 2023
@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member Author

vtjnash commented Oct 7, 2023

@nanosoldier runtests(["MathML", "Finch", "HydroPowerSimulations", "XGPaint", "Minio", "Arrow", "HmtArchive", "SymbolicNumericIntegration", "EnergyCommunity", "HetaSimulator", "HiGHS", "TORA", "MRIReco", "LowLevelParticleFilters", "LinearNoiseApproximation", "DataDrivenSparse", "EHTImages", "GeneticsMakie", "SDEProblemLibrary", "ImageUtils", "MimiRFFSPs", "DataDrivenDMD", "PhysiologyAnalysis", "Symbolics", "EasyABM", "Pyehtim", "Conductor", "MIRT", "Boscia", "GeoStatsBase", "BiochemNetABC", "WaveguideQED", "DelaySSAToolkit", "EpithelialDynamics1D", "ParallelAnalysis", "VoronoiFVM", "ReactionNetworkImporters", "GlobalSensitivity", "QuantumOptics", "Intervals", "PlantGeom", "SummationByPartsOperators"])

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - no new issues were detected.
The full report is available.

@vtjnash vtjnash merged commit aa42963 into master Oct 7, 2023
0 of 4 checks passed
@vtjnash vtjnash deleted the jn/51510-plus branch October 7, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs pkgeval Tests for all registered packages should be run with this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants