Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix typos and grammar #51547

Merged
merged 7 commits into from
Oct 8, 2023
Merged

Docs: fix typos and grammar #51547

merged 7 commits into from
Oct 8, 2023

Conversation

masterujjval
Copy link
Contributor

@masterujjval masterujjval commented Oct 2, 2023 •
edited
Loading

doc: Corrected some sentences.

@christiangnrd
Copy link
Contributor

I would rename the pull request so that it better reflects the changes. Something like "Docs: Fix typos and grammar" would probably be good.

@masterujjval masterujjval changed the title fix: incorrect sentence Docs: fix typos and grammar Oct 2, 2023
@masterujjval
Copy link
Contributor Author

Why the second build is failing?

@brenhinkeller brenhinkeller added the docs This change adds or pertains to documentation label Oct 3, 2023
@masterujjval
Copy link
Contributor Author

masterujjval commented Oct 8, 2023 •
edited
Loading

why my PR has not been merged?

@oscardssmith oscardssmith merged commit e81c8e3 into JuliaLang:master Oct 8, 2023
@oscardssmith
Copy link
Member

just required someone to press the button.

@LilithHafner LilithHafner mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiangnrd christiangnrd christiangnrd left review comments

@fredrikekre fredrikekre fredrikekre left review comments

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@masterujjval @christiangnrd @oscardssmith @fredrikekre @brenhinkeller