Add error on missing ccallable #51514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yup, this is making sure that the test fails instead of falsely succeeding. Before we would fail to find the exported symbol and just for pkg.images, but not the sys image, recreate the entry point while loading the package. This aligns the code paths for both system image and package image, so that we can test the fix :) |
vchuravy
force-pushed
the
vc/ccallable
branch
from
8e7ab1f
to
c2fda42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While mucking about I observed that a
@ccallableadded to Base,will not be exported from the
.so.See how it is marked
HIDDEN.Interestingly enough this works from a pkgimg.
I suspect @pchintalapudi multi-versioning work is to blame.
cc: @KristofferC and @maleadt since this might break some package compiler use-cases.