-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excise FileWatching by moving pidfile to Base #51463
Conversation
The strategy sounds reasonable to me but I defer to @vtjnash about the removal of use of |
bump @vtjnash |
Triage didn't haven anyone who understood these code paths deeply but it seemed like a good idea from the outside.
|
I'm a big fan of excision and want to make sure that this gets any support it needs, but I'm not sure how discussing this on triage would help. Feel free to re-add the label with a note about what specifically you would like discussed. |
Any particular reason for the close? (didn't mean to sound negative. Just interested) |
Mostly me just un-licking the cookie and acknowledging that I won't be able to work on this until I graduated |
@vchuravy you graduated now, right? Reopen? 😆 😆 |
I am slowly redefining what it means to be a stdlib.
Previously we have used stdlibs as a way to organize code,
outside the monolith that is
base/
. With a move towardsstdlibs using pkgimages as their caching mechanism and them
becoming upgradeable, we have to redefine the relationship
between Base and stdlibs.
In my opinion Base should not have a direct dependency on
functionality in standard libraries. If we need something to be used by Base,
we must include the minimal set of functionality.
Functions in Base should either be universally useful,
or require some sort of compiler/runtime support.
Since we are not breaking functionality we must allow for
auto-loading/delayed loading of packages, but that mechanism,
must allow for the loading to fail.
Pidfile support was introduced in #44367, but it only uses
a
watch_file
from FileWatching.jl.Here I moved pidfile.jl to base, removing the usage of FileWatching.
I decided against delayed initialization, since there would be a
rather annoying recusrion potential, and we don't want users to
disallow
@stdlib
and then suddenly have cache races again.