Clean up various naming aspects of codegen #50638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchintalapudi
added
compiler:codegen
gbaraldi
reviewed
Jul 23, 2023
|
It seems we are double printing a symbol somewhere |
pchintalapudi
force-pushed
the
pc/jit-literals
branch
from
c714b17 to
5d209a2
Compare
pchintalapudi
force-pushed
the
pc/cleanups2
branch
from
43fbe90 to
d31d567
Compare
|
Turns out the strings were null-terminated, which caused the weird errors from before. |
vtjnash
reviewed
Jul 24, 2023
vtjnash
approved these changes
Jul 24, 2023
pchintalapudi
commented
Jul 24, 2023
pchintalapudi
force-pushed
the
pc/cleanups2
branch
from
8bf033d to
cc00c95
Compare
pchintalapudi
added
the
merge me
pchintalapudi
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are changing from
const std::string &toconst Twine &, which lets us be lazier about computing string values efficiently. We also make the plt function private linkage since it's only referred to by the plt global.Depends on #50632 (potentially, I haven't checked if there are actual conflicts)