add warning to Iterators.filter about assumptions on predicate
#50497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump |
brenhinkeller
added
docs
timholy
reviewed
Aug 7, 2023
base/iterators.jl
Outdated
Comment on lines
495
to
497
| The implementation may assume that `flt` is pure, so please use caution | ||
| to ensure correctness when the predicate values may be non-deterministic, | ||
| have side-effects, or be dependent on the order of iteration. |
There was a problem hiding this comment.
Can we be more specific about the types of problems that might be encountered? "Please use caution" might be OK for a sign that starts with "Ice forms on bridge, please use caution" but in this context it's not obviously actionable advice. Maybe something like "Predicates that are non-deterministic, ... may not compose well with other operations. In such cases, Base.filter is recommended instead."?
adienes
force-pushed
the
iterator_flt_warning
branch
from
17b9c4b to
689ae53
Compare
adienes
force-pushed
the
iterator_flt_warning
branch
from
689ae53 to
922732b
Compare
|
Very nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #50440