allow newlines in EnvHash values #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added a commit
that referenced
this pull request
Mar 3, 2012
allow newlines in EnvHash values
cmcaine
added a commit
to cmcaine/julia
that referenced
this pull request
Nov 11, 2022
* Change problem definition As I wrote in exercism/julia#503 Thinking about it some more, I think that's because `isvalid` isn't really the right function for us. `isvalid` checks if a string or character contains only valid UTF-8 codepoints. I think it only makes sense for types where the representation of the type (the bits in memory) can encode something invalid in normal use. This is the case for strings because Julia does not validate that strings or characters are correctly encoded when they are created, it just treats them as opaque bytes. For most Julia types, however, you cannot create an invalid value of the type, except through silly use of pointers. I think in real code the advice would be to parse the string into an ISBN type, and if that is not possible (e.g. because the string does not encode a valid ISBN), the ISBN constructor (or `parse(ISBN, s)`, whichever makes more sense) should throw an error. If a non-throwing option is required, `tryparse(ISBN, s)` is the right function to define. Personally, I would define only a constructor and have it throw errors. * Improve docstring * Use the vararg form of print It's slightly faster and maybe better practice. * Remove unused isbn-verifier/.meta/description.md * isbn: update tests and instructions Simplifies the public API of `ISBN` to something that's arguably more realistic and includes enough detail in the description to solve the exercise without reading the tests. * Define an explicit `==` method in isbn-verifier example * write a design.md * better test_nothrows * Clarify where to put the bonus tests Co-authored-by: Sascha Mann <[email protected]> Co-authored-by: Sascha Mann <[email protected]>
jishnub
pushed a commit
that referenced
this pull request
Feb 16, 2024
Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: c9f7293 New commit: cb602d7 Julia version: 1.12.0-DEV SparseArrays version: 1.11.0(Does not match) Bump invoked by: @dkarrasch Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@c9f7293...cb602d7 ``` $ git log --oneline c9f7293..cb602d7 cb602d7 Add generic matmatmul for inplace sparse x sparse (#486) 95575c0 Speedup for `findmin()/findmax()` on sparse arrays (#510) (#511) 4cc31f2 Fix error message in getcommon() in cholmod (#509) 1748989 Move `fkeep!` docstring to the right function (#503) 1aa6431 Update ci.yml timeout (#507) 1f88ae1 Update ci.yml - add codecov token (#504) ``` Co-authored-by: Dilum Aluthge <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Feb 26, 2024
Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: c9f7293 New commit: cb602d7 Julia version: 1.12.0-DEV SparseArrays version: 1.11.0(Does not match) Bump invoked by: @dkarrasch Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@c9f7293...cb602d7 ``` $ git log --oneline c9f7293..cb602d7 cb602d7 Add generic matmatmul for inplace sparse x sparse (#486) 95575c0 Speedup for `findmin()/findmax()` on sparse arrays (#510) (#511) 4cc31f2 Fix error message in getcommon() in cholmod (#509) 1748989 Move `fkeep!` docstring to the right function (#503) 1aa6431 Update ci.yml timeout (#507) 1f88ae1 Update ci.yml - add codecov token (#504) ``` Co-authored-by: Dilum Aluthge <[email protected]> (cherry picked from commit ddd7afb)
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
…aLang#53361) Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: c9f7293 New commit: cb602d7 Julia version: 1.12.0-DEV SparseArrays version: 1.11.0(Does not match) Bump invoked by: @dkarrasch Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@c9f7293...cb602d7 ``` $ git log --oneline c9f7293..cb602d7 cb602d7 Add generic matmatmul for inplace sparse x sparse (JuliaLang#486) 95575c0 Speedup for `findmin()/findmax()` on sparse arrays (JuliaLang#510) (JuliaLang#511) 4cc31f2 Fix error message in getcommon() in cholmod (JuliaLang#509) 1748989 Move `fkeep!` docstring to the right function (JuliaLang#503) 1aa6431 Update ci.yml timeout (JuliaLang#507) 1f88ae1 Update ci.yml - add codecov token (JuliaLang#504) ``` Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvHash() crashes on several of my boxes
because one of my environment variables contains a newline