Remove new BitCastInst unless it's in a typed pointer context
#50338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
reviewed
Jun 29, 2023
| @@ -70,6 +70,7 @@ void LowerPTLS::set_pgcstack_attrs(CallInst *pgcstack) const | |||
|
|
|||
| Instruction *LowerPTLS::emit_pgcstack_tp(Value *offset, Instruction *insertBefore) const | |||
| { | |||
| IRBuilder<> builder(insertBefore); | |||
| Value *tls; | |||
| if (TargetTriple.isX86() && insertBefore->getFunction()->callsFunctionThatReturnsTwice()) { | |||
| // Workaround LLVM bug by hiding the offset computation | |||
There was a problem hiding this comment.
According to #17288 and https://bugs.llvm.org/show_bug.cgi?id=21183, maybe we don't need this workaround anymore? But I guess we can check that in a separate PR
gbaraldi
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be creating random bitcasts in opaque pointer mode since it's inefficient, so this either requires that typed pointers be present to use
new BitCastInstor farms off that responsibility to an IRBuilder.