Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback fro znver3 to be generic #50175

Closed
wants to merge 1 commit into from
Closed

Fix fallback fro znver3 to be generic #50175

wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

Noticed while looking at #50102
Introduced by #45663

I don't fully understand the fallback definition, but every-other CPU uses generic there.

@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Jun 15, 2023
vtjnash
vtjnash reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiger lake and later also use this it look like

@vchuravy
Copy link
Member Author

Ah! E.g. we are encoding which to use if the LLVM version does not support it.

We should update our list for the new lakes and zen4

@vchuravy vchuravy closed this Jun 15, 2023
@vchuravy vchuravy deleted the vc/znver3_fallback branch June 15, 2023 12:43
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchuravy @vtjnash @KristofferC