-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include HermOrSym
in character-based mul!
dispatch
#49865
Conversation
@nanosoldier @nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
@nanosoldier |
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
Just wanted to say that this work to get rid of all those ugly buggy slow Union dispatch has been awesome! |
Your package evaluation job has completed - possible new issues were detected. |
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. |
Okay, so here is the last remaining issue. The character-based dispatch approach now includes symmetric and hermitian matrices. In case the combination of wrappers or the type of the scalars |
I think some extra allocation is fine here considering the extremely bad behavior we are seeing w.r.t |
This extends #49806 to
HermOrSym
types. With this PR, we are down to 33mul!
methods. Can't wait to have -5 methods! 🤣This is in some parts a bit ugly due to the re-wrapping, but that happens only in the very generic paths, so shouldn't affect the fast paths.