Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to LBT v5.7.0 #49281

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Bump to LBT v5.7.0 #49281

merged 1 commit into from
Apr 10, 2023

Conversation

staticfloat
Copy link
Member

This release of libblastrampoline contains two new features: ILP64 Accelerate support, and LAPACK_jll support.

@inkydragon inkydragon added the building Build system, or building Julia or its dependencies label Apr 7, 2023
@ViralBShah ViralBShah added the linear algebra Linear algebra label Apr 7, 2023
inkydragon
inkydragon reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check list

doc: https://github.com/JuliaLang/julia/blob/master/doc/src/devdocs/build/build.md#update-the-version-number-of-a-dependency

Version numbers:

  • deps/$(libname).version: LIBNAME_VER, LIBNAME_BRANCH, LIBNAME_SHA1 and LIBNAME_JLL_VER
  • stdlib/$(LIBNAME_JLL_NAME)_jll/Project.toml: version

Checksum:

  • deps/checksums/$(libname)

Patches:

  • no patch

ViralBShah
ViralBShah reviewed Apr 7, 2023
View reviewed changes
stdlib/libblastrampoline_jll/Project.toml

[deps]
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
Artifacts = "56f22d72-fd6d-98f1-02f0-08ddc0907c33"

[compat]
julia = "1.8"
julia = "1.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this 1.9, so that it can be backported and made available in 1.9.1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we backport, we can set it accordingly. I don't want to set it to 1.9, and then it's only available in 1.9.1

@staticfloat
Bump to LBT v5.7.0
fe84d17 
This release of libblastrampoline contains two new features: ILP64 Accelerate support, and LAPACK_jll support.
@ViralBShah ViralBShah merged commit 4ced71a into master Apr 10, 2023
@ViralBShah ViralBShah deleted the sf/lbt_v570 branch April 10, 2023 18:54
@staticfloat staticfloat added the backport 1.9 Change should be backported to release-1.9 label Apr 10, 2023
KristofferC pushed a commit that referenced this pull request Apr 13, 2023
@staticfloat @KristofferC
Bump to LBT v5.7.0 (#49281)
4498251 
This release of libblastrampoline contains two new features: ILP64 Accelerate support, and LAPACK_jll support.

(cherry picked from commit 4ced71a)
@KristofferC KristofferC mentioned this pull request Apr 13, 2023
Merged
26 tasks
@DilumAluthge
Copy link
Member 

ERROR: The working directory is dirty.
--
Output of git status:
HEAD detached at 46adde9d8d7
Untracked files:
(use "git add <file>..." to include in what will be committed)
 
deps/checksums/blastrampoline-2272604bfb10b9e8a3ae5f1a4569899b99251a65.tar.gz/
 
nothing added to commit but untracked files present (use "git add" to track)
🚨 Error: The command exited with status 1

@DilumAluthge
Copy link
Member

@staticfloat Cam you update the source checksum for LBT?

@ViralBShah
Copy link
Member

@staticfloat Cam you update the source checksum for LBT?

Fixed in #49396

Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@staticfloat @Xnartharax
Bump to LBT v5.7.0 (JuliaLang#49281)
594d8bf 
This release of libblastrampoline contains two new features: ILP64 Accelerate support, and LAPACK_jll support.
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Apr 25, 2023
@amontoison amontoison mentioned this pull request May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralBShah ViralBShah ViralBShah left review comments

@inkydragon inkydragon inkydragon left review comments

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@staticfloat @DilumAluthge @ViralBShah @inkydragon @KristofferC