opaque_closure: Properly set world for OC from inferred CodeInfo #49029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For OpaqueClosures constructed from inferred code, there is only one valid age. We were incorrectly setting the primary world age of the method to `1`, rather than the construction world age of the opaque closure, causing codegen to fail to emit direct calls for :invoke'd statements.
JeffBezanson
approved these changes
Mar 17, 2023
oscardssmith
pushed a commit
to oscardssmith/julia
that referenced
this pull request
Mar 20, 2023
…iaLang#49029) For OpaqueClosures constructed from inferred code, there is only one valid age. We were incorrectly setting the primary world age of the method to `1`, rather than the construction world age of the opaque closure, causing codegen to fail to emit direct calls for :invoke'd statements.
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
…iaLang#49029) For OpaqueClosures constructed from inferred code, there is only one valid age. We were incorrectly setting the primary world age of the method to `1`, rather than the construction world age of the opaque closure, causing codegen to fail to emit direct calls for :invoke'd statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OpaqueClosures constructed from inferred code, there is only one valid age. We were incorrectly setting the primary world age of the method to
1, rather than the construction world age of the opaque closure, causing codegen to fail to emit direct calls for :invoke'd statements.