Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put back DelimitedFiles as a non-sysimage "stdlib" #48671

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Feb 14, 2023

Fixes #48161.

Goes together with JuliaLang/Pkg.jl#3373.

@KristofferC KristofferC added packages Package management and loading stdlib Julia's standard library backport 1.9 Change should be backported to release-1.9 labels Feb 14, 2023
@vchuravy
Copy link
Member

You probably also want to list it in https://github.com/JuliaLang/julia/blob/master/contrib/cache_stdlibs.jl

@KristofferC KristofferC force-pushed the kc/delimtied_files_ship branch from 1bb6cd8 to 3186096 Compare February 14, 2023 16:15
@KristofferC
Copy link
Member Author

I don't know what that file does but I added it to it :)

@vchuravy
Copy link
Member

It creates a cachefile so that the user doesn't need to precompile DelimtedFiles from the stdlib.

@DilumAluthge
Copy link
Member

Can you add the following checksums?

ERROR: The working directory is dirty.
--
  | Output of git status:
  | HEAD detached at 3186096a8eb
  | Untracked files:
  | (use "git add <file>..." to include in what will be committed)
  | deps/checksums/DelimitedFiles-db79c842f95f55b1f8d8037c0d3363ab21cd3b90.tar.gz/
  | stdlib/DelimitedFiles-db79c842f95f55b1f8d8037c0d3363ab21cd3b90/
  |  
  | nothing added to commit but untracked files present (use "git add" to track)
  | 🚨 Error: The command exited with status 1


@DilumAluthge
Copy link
Member

Also, could we add a file stdlib/not-stdlibs.txt with contents:

DelimitedFiles

@KristofferC
Copy link
Member Author

Also, could we add a file stdlib/not-stdlibs.txt with contents:

I didn't really want to couple this PR with the exact way of specifying the mechanism of that. For example a .txt file feels strange.

@KristofferC KristofferC force-pushed the kc/delimtied_files_ship branch from 3186096 to f8229ea Compare February 14, 2023 19:56
@DilumAluthge
Copy link
Member

For example a .txt file feels strange.

We could have a line in stdlib/Makefile of the form:

PKG_DISREGARD = DelimitedFiles Foo Bar Baz

And then Pkg could look for that line?

@KristofferC
Copy link
Member Author

Pkg would look in the Makefile? We don't ship that one do we?

@DilumAluthge
Copy link
Member

Pkg would look in the Makefile? We don't ship that one do we?

Oh whoops, you're right, Pkg can only use what's actually shipped in the final tarball.

@KristofferC KristofferC merged commit 56667bb into master Feb 21, 2023
@KristofferC KristofferC deleted the kc/delimtied_files_ship branch February 21, 2023 12:52
KristofferC added a commit that referenced this pull request Feb 21, 2023
KristofferC added a commit that referenced this pull request Feb 21, 2023
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
@PallHaraldsson
Copy link
Contributor

DelimitedFiles is mentioned in NEWS, or well now HISTORY. Is it outdated, and should be dropped there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Package management and loading stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship remove Stdlibs in 1.9+
4 participants