-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put back DelimitedFiles as a non-sysimage "stdlib" #48671
Conversation
You probably also want to list it in https://github.com/JuliaLang/julia/blob/master/contrib/cache_stdlibs.jl |
1bb6cd8
to
3186096
Compare
I don't know what that file does but I added it to it :) |
It creates a cachefile so that the user doesn't need to precompile DelimtedFiles from the stdlib. |
Can you add the following checksums?
|
Also, could we add a file
|
I didn't really want to couple this PR with the exact way of specifying the mechanism of that. For example a |
3186096
to
f8229ea
Compare
We could have a line in
And then Pkg could look for that line? |
Pkg would look in the |
Oh whoops, you're right, Pkg can only use what's actually shipped in the final tarball. |
(cherry picked from commit 56667bb)
(cherry picked from commit 56667bb)
DelimitedFiles is mentioned in NEWS, or well now HISTORY. Is it outdated, and should be dropped there? |
Fixes #48161.
Goes together with JuliaLang/Pkg.jl#3373.