deprecate @pure and make it just @assume_effects :foldable #48588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Feb 8, 2023
vchuravy
reviewed
Feb 8, 2023
vchuravy
reviewed
Feb 8, 2023
vchuravy
reviewed
Feb 8, 2023
|
Ideally this would remove the |
vchuravy
reviewed
Feb 8, 2023
Co-authored-by: Valentin Churavy <[email protected]>
aviatesk
requested changes
Feb 9, 2023
| # TODO: this used to trigger a bug in inference recursion detection, and is unmaintained now | ||
| # sigtuple = unwrap_unionall(sig)::DataType | ||
| # splitunions = 1 < unionsplitcost(sigtuple.parameters) * napplicable <= InferenceParams(interp).max_union_splitting | ||
| if splitunions |
There was a problem hiding this comment.
Please don't remove this branch. We have kinda maintained this branch since we may enable it again in the future. And this change is unrelated to this PR.
| @@ -2022,7 +1969,7 @@ function abstract_call_known(interp::AbstractInterpreter, @nospecialize(f), | |||
| if isa(rty, Conditional) | |||
| return CallMeta(Conditional(rty.slot, rty.elsetype, rty.thentype), EFFECTS_TOTAL, NoCallInfo()) # swap if-else | |||
| elseif isa(rty, Const) | |||
| return CallMeta(Const(rty.val === false), EFFECTS_TOTAL, MethodResultPure()) | |||
There was a problem hiding this comment.
Don't remove MethodResultPure. This would result in bad performance.
There was a problem hiding this comment.
couldn't this just check the effects rather than using MethodResultPure?
There was a problem hiding this comment.
We currently don't propagate per-statement level effects. CallInfo is what we use for propagating per-statement information to the optimizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point the effects system is the better way to express these types of guarantees. (Also @vtjnash told me this was OK).