Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out subtype test that causes hang due to StackOverflowError #47792

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Dec 3, 2022

My working theory is that we hit a stack-overflow when calling malloc.

Thread 1 received signal SIGSEGV, Segmentation fault.
0x00007f237c29559e in ?? () from target:/lib/x86_64-linux-gnu/libc.so.6
(rr) bt 10
#0  0x00007f237c29559e in ?? () from target:/lib/x86_64-linux-gnu/libc.so.6
#1  0x00007f237c2975fa in malloc () from target:/lib/x86_64-linux-gnu/libc.so.6
#2  0x00007f237b641e8c in malloc_s (sz=520) at /cache/build/default-amdci5-4/julialang/julia-master/src/support/dtypes.h:339
#3  save_env (root=root@entry=0x0, se=se@entry=0x7f235d4dd460, e=<optimized out>, e=<optimized out>) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:177
#4  0x00007f237b64ac64 in intersect (x=x@entry=0x7f2355d9bbf0, y=y@entry=0x7f2355d9bd90, e=e@entry=0x7f235d4e0a40, param=param@entry=0) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:3164
#5  0x00007f237b64c7bc in intersect_all (x=x@entry=0x7f2355d9bbf0, y=y@entry=0x7f2355d9bd90, e=e@entry=0x7f235d4e0a40) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:3281
#6  0x00007f237b64cee2 in intersect_aside (x=x@entry=0x7f2355d9bbf0, y=y@entry=0x7f2355d9bd90, e=0x7f235d4e0a40, d=<optimized out>, R=0) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:2147
#7  0x00007f237b64d5e4 in intersect_var (b=b@entry=0x7f2355d9bcd0, a=a@entry=0x7f2355d9bd90, e=e@entry=0x7f235d4e0a40, R=R@entry=0 '\000', param=param@entry=0) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:2402
#8  0x00007f237b64a12f in intersect (x=0x7f2355d9bcd0, y=y@entry=0x7f2355d9bd90, e=e@entry=0x7f235d4e0a40, param=param@entry=0) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:3135
#9  0x00007f237b64e020 in intersect_union (x=x@entry=0x7f2355d9bd90, u=u@entry=0x7f2355d9e8f0, e=0x7f235d4e0a40, R=R@entry=0 '\000', param=param@entry=0) at /cache/build/default-amdci5-4/julialang/julia-master/src/subtype.c:2170
(More stack frames follow...)

And then we hang due to something like #28908

@vchuravy vchuravy changed the title Debug hangs introduced by serializer change Comment out subtype test that causes hang due to StackOverflowError Dec 3, 2022
@vchuravy vchuravy marked this pull request as ready for review December 3, 2022 21:01
@vchuravy vchuravy requested a review from vtjnash December 3, 2022 21:01
@vchuravy
Copy link
Member Author

vchuravy commented Dec 3, 2022

This looks like an alternative to #47776 for now.

@vchuravy vchuravy merged commit 327b7ac into master Dec 3, 2022
@vchuravy vchuravy deleted the vc/debug_overflow branch December 3, 2022 23:26
@IanButterworth
Copy link
Member

I guess this should be backported too then?

@IanButterworth IanButterworth added the backport 1.9 Change should be backported to release-1.9 label Dec 5, 2022
@StefanKarpinski
Copy link
Member

You can also use @test_skip which doesn't run the test code.

KristofferC pushed a commit that referenced this pull request Dec 8, 2022
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants