-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REPL keybinding CTRL-Q for stdlib methods #47637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
approved these changes
Nov 19, 2022
fredrikekre
added
backport 1.8
Change should be backported to release-1.8
backport 1.9
Change should be backported to release-1.9
backport 1.6
Change should be backported to release-1.6
labels
Nov 19, 2022
Will this let us re-land #46420? That had seem to make people upset that they encountered this issue more frequently |
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
(cherry picked from commit 7514bcf)
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
(cherry picked from commit 7514bcf)
51 tasks
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 7514bcf)
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 7514bcf)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 7514bcf)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 7514bcf)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 7514bcf)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 7514bcf)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 7514bcf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when editing methods in stdlibs with CTRL-Q from stack traces leads to #26314. For example, for v1.8.3 the following code:
and typing "3[CTRL-Q]" opens the file: "/cache/build/default-amdci5-6/julialang/julia-release-1-dot-8/usr/share/julia/stdlib/v1.8/Printf/src/Printf.jl"
This change fixes it. I tested it by adding a custom keybinding with this fix.