ensure bindings handle write barriers for ty and globalref #47580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
bugfix
JeffBezanson
approved these changes
Nov 15, 2022
This has probably been wrong for a long time (since being introduced in 7908246).
DilumAluthge
force-pushed
the
jn/binding_wb_roots
branch
from
71bba80 to
8411507
Compare
KristofferC
pushed a commit
that referenced
this pull request
Nov 17, 2022
KristofferC
pushed a commit
that referenced
this pull request
Nov 17, 2022
51 tasks
DilumAluthge
removed
the
merge me
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
78 tasks
NHDaly
pushed a commit
that referenced
this pull request
May 15, 2023
This has probably been wrong for a long time (since being introduced in 7908246).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has probably been wrong for a long time (since being introduced in 7908246). Just noticed it during routine code reading, so I have no examples of misbehavior from it.