fix up Conditional-forwarding for vararg methods
#47438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Conditional` is imposed on argument that is squashed to vararg-tuple then we don't need to `widenconditional` on `isva_given_argtypes` (because `Conditional`-information is already widened during the conversion to that vararg-tuple type -- since `PartialStruct` now never wraps slot wrappers with the explicit check within its constructor). Fixes #47435.
aviatesk
added
compiler:inference
vtjnash
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Conditionalis imposed on argument that is squashed to vararg-tuple then we don't need towidenconditionalonisva_given_argtypes(becauseConditional-information is already widened during the conversion to that vararg-tuple type -- sincePartialStructnow never wraps slot wrappers with the explicit check within its constructor).Fixes #47435.