Incomplete fix/workaround for broadcast static type inference (#4673) #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ang#4673) This attempts to infer the dimensionality of the returned array, although this only works for cases of sufficiently low dimensionality.
JeffBezanson
added a commit
that referenced
this pull request
Nov 8, 2013
Incomplete fix/workaround for broadcast static type inference (#4673)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the order of broadcast function definitions to work around #4675.(No longer necessary since bfe8986). It also attempts to fix static type inference for the dimensionality of the returned array to fix #4673, although this only works for cases of sufficiently low dimensionality (code_typed(.*, (Matrix{Float64}, Array{Float64, 8}))works, butcode_typed(.*, (Matrix{Float64}, Array{Float64, 9}))does not;code_typed(.*, (Matrix{Float64}, Matrix{Float64}, Matrix{Float64}))works butcode_typed(.*, (Matrix{Float64}, Matrix{Float64}, Array{Float64, 3}))does not).I'm not fully satisfied with this, but I'm putting it out there in case someone has an idea of how to make it more satisfactory.