Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LAPACK test: don't call sygvd! on undefed matrix #47397

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix LAPACK test: don't call sygvd! on undefed matrix #47397

merged 1 commit into from
Nov 2, 2022

Conversation

dkarrasch
Copy link
Member

@dkarrasch dkarrasch added test This change adds or pertains to unit tests linear algebra Linear algebra merge me PR is reviewed. Merge when all tests are passing labels Oct 31, 2022
@dkarrasch
Copy link
Member Author

dkarrasch commented Oct 31, 2022 •
edited
Loading

Is this also a test issue on v1.6? Should we backport this to v1.6 and v1.8? @KristofferC

@KristofferC
Copy link
Member

Might as well

@dkarrasch dkarrasch added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 labels Nov 1, 2022
@Keno
Copy link
Member

Keno commented Nov 1, 2022

The same pattern is used in a bunch of other places in this file also.

@N5N3
Copy link
Member

N5N3 commented Nov 2, 2022 •
edited
Loading

The error should come from #47074, which adds NaN check before the dimension check.
So this should be a fresh (and limited) CI regression. Perhaps there's no need to backport.

@dkarrasch
Copy link
Member Author

Nice catch! That means we don't need to fix the pattern elsewhere and can just merge it without any backport.

@dkarrasch dkarrasch merged commit 22fe28b into master Nov 2, 2022
@dkarrasch dkarrasch deleted the dk/lapacktest branch November 2, 2022 09:04
@DilumAluthge DilumAluthge removed backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 merge me PR is reviewed. Merge when all tests are passing labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LinearAlgebra/lapack error on CI in sygvd
6 participants
@dkarrasch @KristofferC @Keno @N5N3 @vtjnash @DilumAluthge