Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documenter 0.27.23 => 1.2.1 #47105
Update Documenter 0.27.23 => 1.2.1 #47105
Changes from 37 commits
b24944a
fdcbbdf
d64539f
c0e8bcc
44d2b51
260b543
c906cc9
551d1ce
3a4bbc0
785b992
6adff0f
8a51395
8b92c66
d26fa71
3cfa052
1b1e3c0
e84df37
e381d5e
8bb645e
be67eb4
6a63130
64cb40f
b91849c
317d3d8
816b5b5
608bb07
c407135
a78d2dd
4532811
81a3f81
305c51d
2b621de
a9018b4
e433597
f0b7302
121bdc9
3da55b3
ff0da64
369685e
2eeeac1
012cf21
d272c96
0db360d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you added a dep on
LibGit2
forLibGit2.GITHUB_REGEX
here and Documenter.jl also depends on LibGit2. Is this info statement because Documentor also uses git via shelling out? If not it may be misleading. (somewhat related: JuliaLang/Pkg.jl#2679)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a debug print and I'll remove this. Generally, I need to do a pass on this PR before we merge, to clean it all up.
The issue I ran into here was that Git on the Windows runners is ancient (and I was trying to figure out what version it is exactly). But I resolved that by switching Documenter to Git.jl (which is the better than relying on the system's
git
binary anyway).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note here though: kinda silly to depend on LibGit2 just for this regex nowadays. JuliaDocs/Documenter.jl#2363