make CanonicalIndexError an Exception type #47008
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
merge me
DilumAluthge
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Oct 27, 2022
(cherry picked from commit 7085703)
37 tasks
KristofferC
pushed a commit
that referenced
this pull request
Oct 28, 2022
(cherry picked from commit 7085703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears
CanonicalIndexErrorwas mistakenly not declared to be a subtype ofException, so I have fixed this and added a test.Should be backported to 1.8, where
CanonicalIndexErrorwas added.Aside: it may be worth adding some generic type-hierarchy tests. e.g. any
*Errortype should be anException. Or@test_throws FooError ...could check thatFooError <: Exception(this is how I came across this in the first place).