Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compat note for @testset foo() #46980

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Add compat note for @testset foo() #46980

merged 2 commits into from
Oct 2, 2022

Conversation

Seelengrab
Copy link
Contributor

@Seelengrab Seelengrab commented Sep 29, 2022 •
edited
Loading

Seems like I forgot this in #42518 since the PR took quite a while to get merged, so this adds that.

giordano
giordano reviewed Sep 29, 2022
View reviewed changes
stdlib/Test/src/Test.jl Outdated Show resolved Hide resolved
@giordano giordano added the backport 1.8 Change should be backported to release-1.8 label Sep 29, 2022
@KristofferC KristofferC mentioned this pull request Sep 30, 2022
Merged
37 tasks
@LilithHafner LilithHafner added testsystem The unit testing framework and Test stdlib docs This change adds or pertains to documentation labels Oct 2, 2022
@LilithHafner LilithHafner merged commit 45fd204 into JuliaLang:master Oct 2, 2022
@Seelengrab Seelengrab deleted the testset_call_compat branch October 2, 2022 09:58
KristofferC pushed a commit that referenced this pull request Oct 27, 2022
@Seelengrab @KristofferC
Add compat note for @testset foo() (#46980)
2dbdb51 
Co-authored-by: Sukera <[email protected]>
(cherry picked from commit 45fd204)
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@Seelengrab @KristofferC
Add compat note for @testset foo() (#46980)
2e16916 
Co-authored-by: Sukera <[email protected]>
(cherry picked from commit 45fd204)
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@Seelengrab @KristofferC
Add compat note for @testset foo() (#46980)
40c3778 
Co-authored-by: Sukera <[email protected]>
(cherry picked from commit 45fd204)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Seelengrab @giordano @KristofferC @LilithHafner