-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve inferrability of create_expr_cache
#46801
base: master
Are you sure you want to change the base?
Conversation
Bump |
Bump |
1 similar comment
Bump |
This fixes some invalidations when loading HDF5.jl
be8dc69
to
0340af1
Compare
CI looks really sad so I rebased it again. |
The has already been reviewed/"approved", just Jeff busy or waiting for CI to not fail or just end...? PowerPC is still running for a long time, has failures (false alarms?) and/or CI needs restarting? |
I think the CI failure in here is related so they have to be fixed for this to be able to get merged. |
CI runs of buildkite fail with
Does anybody know how this might be related? |
I improved type stability to fix some invalidations. This is based on the following code:
The majority of invalidations from loading HDF5.jl are fixed by JuliaLang/Pkg.jl#3202 but I discovered these along the way, too, so I can also fix them here.