Also merge var with unchanged bounds. #46757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not skip it as the current `env` might not be valid if the var's bounds get fixed (by another Unions decision.)
N5N3
added
types and dispatch
vtjnash
reviewed
Sep 14, 2022
and remove the unneeded Null check. Co-Authored-By: Jameson Nash <[email protected]>
N5N3
force-pushed
the
more_env_merge
branch
from
f1a660b to
40f8395
Compare
28 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Also merge var with unchanged bounds. The current `env` might not be valid if the var's bounds get fixed by another Unions decision. * Replace `v->var->lb` with `simple_meet` * Remove the unneeded NUll check. Co-Authored-By: Jameson Nash <[email protected]> (cherry picked from commit 6557542)
aviatesk
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Also merge var with unchanged bounds. The current `env` might not be valid if the var's bounds get fixed by another Unions decision. * Replace `v->var->lb` with `simple_meet` * Remove the unneeded NUll check. Co-Authored-By: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I skipped it as I thought unchanged bounds means there's no restriction added on this var.
But examples from #46735 show that it should not be skiped as the current
envmight not be valid if the var's bounds get fixed (by another Unions decision.)close #46735. Test added.