fix issue #46665, prod(::Array{BigInt})
#46667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
force-pushed
the
rf/fix-prod-bigint
branch
2 times, most recently
from
a8911ff to
53bef9a
Compare
rfourquet
added
bugfix
The way we were counting the number of bits was assigning a negative number to `0`, which could lead to a negative total number of bits. Better to just exit early in this case. Also, the estimate was slightly off because we were counting the number of leading zeros in the least significant limb, instead of the most significant.
rfourquet
force-pushed
the
rf/fix-prod-bigint
branch
from
53bef9a to
e11f2ff
Compare
JeffBezanson
approved these changes
Sep 7, 2022
KristofferC
pushed a commit
that referenced
this pull request
Sep 16, 2022
The way we were counting the number of bits was assigning a negative number to `0`, which could lead to a negative total number of bits. Better to just exit early in this case. Also, the estimate was slightly off because we were counting the number of leading zeros in the least significant limb, instead of the most significant. (cherry picked from commit f7b4ebe)
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were counting the number of bits was assigning a negative number to
0, which could lead to a negative total number of bits. Better to just exit early in this case.Also, the estimate was slightly off because we were counting the number of leading zeros in the least significant limb, instead of the most significant.