inference: allow semi-concrete interpretation on non-inlineable code #46637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we require `const_prop_methodinstance_heuristic` to do the semi-concrete interpretation, and thus non-inlineable functions are not eligible for the semi-concrete interpretation. Especially that can happen for function marked with `@noinline`. This commit drops the condition for the semi-concrete interpretation, and widens the eligibility of it.
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
I'm not opposed to it, but I am somewhat worried about it. The restriction to inlineable makes sense because we're gonna uncompress the IR and mess with it. We'll do that anyway for inlining, so there's not a lot lost if it's unprofitable. I'm worried about the performance implications of making this much wider. |
|
Right. We should probably close this PR for now. We may revisit it with a more sophisticated constprop/inlining heuristic as experimented at #46471. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we require
const_prop_methodinstance_heuristicto do thesemi-concrete interpretation, and thus non-inlineable functions are
not eligible for the semi-concrete interpretation.
Especially that can happen for function marked with
@noinline.This commit drops the condition for the semi-concrete interpretation,
and widens the eligibility of it.