Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepcopy for Base.GenericCondition #46406

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

DilumAluthge
Copy link
Member

Fixes #46405 (which was introduced in #43325).

@DilumAluthge DilumAluthge added backport 1.8 Change should be backported to release-1.8 parallelism Parallel or distributed computation multithreading Base.Threads and related functionality labels Aug 19, 2022
@DilumAluthge DilumAluthge marked this pull request as ready for review August 19, 2022 04:25
@DilumAluthge DilumAluthge requested a review from vtjnash August 19, 2022 04:26
@DilumAluthge DilumAluthge requested a review from tkf August 21, 2022 03:21
@DilumAluthge DilumAluthge force-pushed the dpa/deepcopy-generic-condition branch from 0ce485a to ec0760e Compare August 21, 2022 03:24
@DilumAluthge DilumAluthge added the bugfix This change fixes an existing bug label Aug 21, 2022
@KristofferC KristofferC merged commit 99e8953 into master Aug 22, 2022
@KristofferC KristofferC deleted the dpa/deepcopy-generic-condition branch August 22, 2022 14:34
KristofferC pushed a commit that referenced this pull request Aug 26, 2022
KristofferC pushed a commit that referenced this pull request Aug 26, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug multithreading Base.Threads and related functionality parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in deepcopy(Base.GenericCondition(ReentrantLock())) from 1.7.3 to 1.8.0 (also present on master)
2 participants