Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run ;cmd through a shell #4635

Merged
merged 3 commits into from
Oct 25, 2013
Merged

run ;cmd through a shell #4635

merged 3 commits into from
Oct 25, 2013

Conversation

StefanKarpinski
Copy link
Member

I like this behavior a lot better – it behaves like your shell, which is really much nicer. If people like this, I think we should do it. There is a remaining issue with it, however, which is that there's no way to use shell variables.

@timholy
Copy link
Member

timholy commented Oct 25, 2013

Are there any performance implications? For example, the time it takes to start up the shell?

@StefanKarpinski
Copy link
Member Author

It seems reasonably fast to me and since it's a strictly interactive feature, if it feels fast enough, it is fast enough.

@pao
Copy link
Member

pao commented Oct 25, 2013

This appears like it will be horrifically broken on Windows.

@StefanKarpinski
Copy link
Member Author

Ah, that's a good point. I guess on Windows since there's no shell, we can just skip this.

@StefanKarpinski
Copy link
Member Author

This is so much nicer than the old behavior, I just have to merge this. Supporting shell variable interpolation strikes me as unimportant since any programming with variables should probably be done in Julia land instead.

StefanKarpinski added a commit that referenced this pull request Oct 25, 2013
@StefanKarpinski StefanKarpinski merged commit 1f3289c into master Oct 25, 2013
@StefanKarpinski StefanKarpinski deleted the sk/shell branch November 16, 2013 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants