Lazily initialize Profile buffer #46239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Aug 2, 2022
IanButterworth
force-pushed
the
ib/profile_lazy_buffer
branch
from
4c75b0a to
79ad2c7
Compare
IanButterworth
force-pushed
the
ib/profile_lazy_buffer
branch
from
17e211e to
f6241a5
Compare
IanButterworth
force-pushed
the
ib/profile_lazy_buffer
branch
from
acd1fc0 to
4be4ea0
Compare
32 tasks
IanButterworth
added a commit
that referenced
this pull request
Aug 7, 2022
(cherry picked from commit 72473ae)
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Profileis in the sysimage, its__init__()that currently sets the buffer up is called during julia startup, meaning that the profile buffer is allocated during julia startup whether or not you're using Profile.This changes the default init to be lazy, at the time of the first
@profilecall.Hoping to alleviate issues like #45434
Todo:
SIGINFO/SIGUSR1request. We can't call the juliadefault_init()code there.. Update: Now initialized with default values if needed directly by trigger_profile_peek