-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix convert call in Artifacts.jl #46040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Jul 14, 2022
vchuravy
added
backport 1.8
Change should be backported to release-1.8
needs tests
Unit tests are required for this change
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Jul 14, 2022
vchuravy
approved these changes
Jul 14, 2022
Regarding needs test, this might be dead code for all I know so it's mostly to silence the linter warning. |
KristofferC
added a commit
that referenced
this pull request
Jul 17, 2022
(cherry picked from commit e96b19d)
32 tasks
KristofferC
added a commit
that referenced
this pull request
Jul 20, 2022
(cherry picked from commit e96b19d)
78 tasks
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
KristofferC
added a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit e96b19d)
KristofferC
added a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit e96b19d)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit e96b19d)
KristofferC
added a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit e96b19d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.6
Change should be backported to release-1.6
needs tests
Unit tests are required for this change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened to see this in the VSCode linter.