Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-1.8: Backports for 1.8-rc3 #45986

Merged
merged 3 commits into from
Jul 12, 2022
Merged

release-1.8: Backports for 1.8-rc3 #45986

merged 3 commits into from
Jul 12, 2022

Conversation

KristofferC
Copy link
Member

(cherry picked from commit 69f10f8)

fixes #45979

@fxcoudert @KristofferC
Update nghttp2 to 1.47.0 (#45408)
5c5d54a 
(cherry picked from commit 69f10f8)
@KristofferC KristofferC added the release Release management and versioning. label Jul 10, 2022
@giordano giordano linked an issue Jul 10, 2022 that may be closed by this pull request
[1.8.0-rc2][macOS] could not load library "@rpath/libcurl.4.dylib" error #45979
Closed
@KristofferC KristofferC reopened this Jul 10, 2022
@KristofferC
Copy link
Member Author

I seem to consistently be getting

Error During Test at /cache/build/default-amdci4-2/julialang/julia-release-1-dot-8/julia-5c5d54aa3b/share/julia/stdlib/v1.8/Downloads/test/runtests.jl:453
  Got exception outside of a @test
  HTTP/2 200 (Operation too slow. Less than 1 bytes/sec transferred the last 20 seconds) while requesting https://httpbingo.org/drip
  Stacktrace:
    [1] (::Downloads.var"#9#18"{IOStream, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Main.Test12Main_Downloads.var"#28#54"{Vector{Any}}, Bool, Nothing, Bool, String, Bool, Bool})(easy::Downloads.Curl.Easy)
      @ Downloads /cache/build/default-amdci4-2/julialang/julia-release-1-dot-8/julia-5c5d54aa3b/share/julia/stdlib/v1.8/Downloads/src/Downloads.jl:387
    [2] with_handle(f::Downloads.var"#9#18"{IOStream, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Main.Test12Main_Downloads.var"#28#54"{Vector{Any}}, Bool, Nothing, Bool, String, Bool, Bool}, handle::Downloads.Curl.Easy)
      @ Downloads.Curl /cache/build/default-amdci4-2/julialang/julia-release-1-dot-8/julia-5c5d54aa3b/share/julia/stdlib/v1.8/Downloads/src/Curl/Curl.jl:88
    [3] #8
      @ /cache/build/default-amdci4-2/julialang/julia-release-1-dot-8/julia-5c5d54aa3b/share/julia/stdlib/v1.8/Downloads/src/Downloads.jl:328 [inlined]
...

in the Downloads test with this :/

@giordano
Copy link
Contributor

But #45408 has been merged 2 months ago on master, it doesn't seem to have been particularly problematic since then.

@KristofferC
Copy link
Member Author

Well, I see this on both the linux runners that run the Downloads.jl tests and even after a restart. But maybe that endpoint is just down and it is not related to this.

@giordano
Copy link
Contributor

Tests for i686-linux-gnu and win64 are currently failing with the same errors also for #45823, which is totally unrelated.

@KristofferC KristofferC reopened this Jul 11, 2022
@KristofferC KristofferC reopened this Jul 11, 2022
@KristofferC KristofferC reopened this Jul 11, 2022
@DilumAluthge
Copy link
Member

Closing and reopening doesn't retrigger Buildkite. I contacted support, and they told me that's the intended behavior.

To retry a failing Buildkite job, you'll need to go to the Buildkite page and click the retry button for the desired jobs.

@KristofferC
Copy link
Member Author

Ouch hah! I tried login and it just tells me I am not in the correct github group, or something like that.

@giordano
Copy link
Contributor

giordano commented Jul 11, 2022 •
edited
Loading

they told me that's the intended behavior.

😐

kpamnany and others added 2 commits July 12, 2022 08:37
@kpamnany @KristofferC
Add channel state checks to reduce exceptions
bf46593 
In channel iteration and in the `@sync` race check.

(cherry picked from commit 4084f7e)
@staticfloat @KristofferC
Update Documenter version, deploy to tarball (#45988)
9f5e58a 
* Update `Documenter` version, deploy to tarball

This is a necessary change to get documentation deployed in buildkite,
where we deploy first to a tarball, then upload in a separate step.

* Update doc/make.jl

Co-authored-by: Morten Piibeleht <[email protected]>

Co-authored-by: Morten Piibeleht <[email protected]>
(cherry picked from commit 43dac09)
@KristofferC KristofferC changed the title release-1.8: Update nghttp2 to 1.47.0 (#45408) release-1.8: Backports for 1.8-rc3 Jul 12, 2022
@DilumAluthge
Copy link
Member

I'm going to reach out to Buildkite support again to see if they'll reconsider adding the "rebuild when a PR is closed and reopened" feature.

@giordano
Copy link
Contributor

I mean, this is related to the fact they don't build on the merge commit but the tip of the branch. Closing and reopening a PR never changes the tip, you have to actually change that somehow (amend, rebase, whatever)

@KristofferC KristofferC merged commit 2d14390 into release-1.8 Jul 12, 2022
@KristofferC KristofferC deleted the backports-release-1.8 branch July 12, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.8.0-rc2][macOS] could not load library "@rpath/libcurl.4.dylib" error
6 participants
@KristofferC @giordano @DilumAluthge @fxcoudert @kpamnany @staticfloat