Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export jl_is_foreign_type #45890

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Export jl_is_foreign_type #45890

merged 3 commits into from
Jul 20, 2022

Conversation

fingolfin
Copy link
Member

Perhaps this could be backported to 1.8 and even 1.7 (where jl_is_foreign_type was first introduced)?

@fingolfin
Copy link
Member Author

Ping? It would still be really nice to get this into 1.8

@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Jul 18, 2022
@vchuravy vchuravy added the merge me PR is reviewed. Merge when all tests are passing label Jul 18, 2022
@DilumAluthge DilumAluthge reopened this Jul 18, 2022
@DilumAluthge
Copy link
Member

(Closing/reopening to trigger Buildbot.)

@vchuravy vchuravy merged commit 8378d4c into JuliaLang:master Jul 20, 2022
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Merged
32 tasks
@KristofferC
Copy link
Member

Could have squashed this.

@fingolfin fingolfin deleted the mh/export-jl_is_foreign_type branch July 20, 2022 08:05
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jul 21, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fingolfin @DilumAluthge @KristofferC @vchuravy