Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib/jll] Automatic include of all *.version makefile #45851

Merged

Conversation

inkydragon
Copy link
Member

we don't have to update manually here (all_jlls.version) in the future

Originally posted by @ViralBShah in #45720 (comment)

@ViralBShah ViralBShah merged commit bd7bd5e into JuliaLang:master Jun 30, 2022
@ViralBShah
Copy link
Member

@giordano Do you recollect why utf8proc, libwhich and patchelf don't have JLLs? I see some Yggdrasil PRs for utf8proc recently, but perhaps the other two have issues with cross-compilation?

@giordano
Copy link
Contributor

I don't think any of those are runtime dependencies of Julia

@giordano
Copy link
Contributor

BTW, we do have Patchelf_jll.jl, but not libwhich (probably because no one needed it badly enough). I though the question was why we don't have these as JLL stdlibs bundled in Julia, to which the answer is what I wrote above.

@ViralBShah
Copy link
Member

ViralBShah commented Jun 30, 2022

Would downloading these from Yggdrasil just makes all the dependency management process uniform, even if only at compile time? And perhaps might have a small (possibly too small to matter) improvement in build times.

@inkydragon inkydragon deleted the deps-load-all-jll-version-file branch July 1, 2022 02:16
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants