Reland "gc: avoid cpu stalls when starting" #45794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/rr-cpu-unstall-2gc
branch
from
742f4a5 to
42caea2
Compare
vtjnash
force-pushed
the
jn/rr-cpu-unstall-2gc
branch
from
42caea2 to
a1ef2f3
Compare
|
Would be good to get someone to look these over. Though many more of these problems have been introduced into gc.c since I wrote this PR, so those need to be fixed now too (most of those look like they simply should have been uv_barriers, so that at least is much simpler). |
vtjnash
commented
Dec 13, 2023
vtjnash
force-pushed
the
jn/rr-cpu-unstall-2gc
branch
from
a1ef2f3 to
0f20c06
Compare
vtjnash
added
multithreading
This reverts commit 4801b6c and adds the safepoints needed to catch the unsafe->safe transition also and the locks needed for the condition broadcast message to be seen.
Could be observed by thread 0 during certain phases, since if the dying thread was not running, it was not supposed to call jl_wakeup_thread (which will not increment nrunning until after the wakeup).
vtjnash
force-pushed
the
jn/rr-cpu-unstall-2gc
branch
from
0f20c06 to
ab1dda2
Compare
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4801b6c and adds
the safepoints needed to catch the unsafe->safe transition also.