Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #45703, assertion failure in subtyping #45771

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix #45703, assertion failure in subtyping #45771

merged 1 commit into from
Jun 27, 2022

Conversation

JeffBezanson
Copy link
Member

fix #45703

@JeffBezanson JeffBezanson added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug backport 1.8 Change should be backported to release-1.8 labels Jun 21, 2022
@JeffBezanson JeffBezanson marked this pull request as ready for review June 21, 2022 23:06
@vtjnash
Copy link
Member

vtjnash commented Jun 27, 2022

I don't know how you messed up the co-scheduler with this

Test Failed at C:\buildbot\worker-tabularasa\tester_win64\build\share\julia\test\threads_exec.jl:909
  Expression: (current_task()).sticky == false
   Evaluated: true == false

@vtjnash vtjnash merged commit 8ccf2d6 into master Jun 27, 2022
@vtjnash vtjnash deleted the jb/fix45703 branch June 27, 2022 17:06
@vtjnash
Copy link
Member

vtjnash commented Jun 27, 2022

(squash-merged with a fixed commit message that says what is changed instead of just having a number)

KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@JeffBezanson
fix obvious_subtype bug with egal objects (#45771)
f6e0600 
When egal objects contain identical typevars with different
environments, the resulting subtyping might not be so obvious.

Fix #45703

(cherry picked from commit 8ccf2d6)
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@JeffBezanson
fix obvious_subtype bug with egal objects (#45771)
5894899 
When egal objects contain identical typevars with different
environments, the resulting subtyping might not be so obvious.

Fix #45703

(cherry picked from commit 8ccf2d6)
@KristofferC KristofferC mentioned this pull request Jul 5, 2022
Merged
36 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 6, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@JeffBezanson @pcjentsch
fix obvious_subtype bug with egal objects (JuliaLang#45771)
a714bb5 
When egal objects contain identical typevars with different
environments, the resulting subtyping might not be so obvious.

Fix JuliaLang#45703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing Diagonalization asserts on 1.8 in subtyping
3 participants
@JeffBezanson @vtjnash @KristofferC