-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix libblastrampoline full source build to install into the right location #45746
Conversation
f12cd2f
to
6089df9
Compare
cc @inkydragon |
I guess we already has: Lines 20 to 24 in 3efc725
Maybe we need to update the version? AND apply this patch: Line 18 in 3efc725
- $(MAKE) -C $(BUILDDIR)/$(BLASTRAMPOLINE_SRC_DIR)/src $(MAKE_COMMON) install
+ $(MAKE) -C $(BUILDDIR)/$(BLASTRAMPOLINE_SRC_DIR)/src install $(MAKE_COMMON) DESTDIR="$2" |
I see that INSTALL_NAME_CMD is in there, but I wonder why adding this helped. I agree we should hold off on this until LBT is bumped and the other PR gets merged. Hopefully it won't be necessary. |
Without If you check |
Should DESTDIR be |
Use DESTDIR to install into
@inkydragon This also fixes the staged full source build, which was not working earlier. |
While we should certainly turn off the mbedtls testing in the full source build, it would anyways be a good idea for python3 to be available on the buildbots. @DilumAluthge Thoughts? |
…ation (JuliaLang#45746) * Bump LBT to 5.1.1 * Use DESTDIR to install into * Update LBT checksums
As suggested by @inkydragon below, fix the LBT source build.
CHOLMOD full source build was unable to find the BLAS, but should be fixed with this PR.