-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Statistics out of the sysimage #45594
Conversation
And remove uses of it in the manual and tests.
The main argument is that |
@nanosoldier |
This is just moving out of the sysimage, so should be practically risk free. |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
I don't see anything suspicious in the 23 new package test failures reported by Nanosoldier. |
We should merge once @KristofferC gives a green light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine. Fully moving it out requires a little bit of thinking about how to deal with compat but I have a strategy that I think should work.
And remove uses of it in the manual and tests.
Follow-up from #44247. Should probably run PkgEval if the PR looks OK.
I'd suggest trying this, and only move
mean
and/orstd
to Base if people complain too loudly before 1.9 is released. Personally I would rather keep these in Statistics to be group statistics function in a single package at last (merging with StatsBase). This makes sense e.g. because these have methods taking weight vectors that we have considered turning into a keyword argument. Alsostd
relies onvar
so these cannot really be separated.