Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap. #45578

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap. #45578

merged 4 commits into from
Aug 29, 2022

Conversation

metab0t
Copy link
Contributor

@metab0t metab0t commented Jun 4, 2022

Fix #45574

@metab0t
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
a0c4f21 
…s do not overlap.

Resizing of BitSet should be filled with 0 by default.
@metab0t metab0t force-pushed the fix_bitset_union branch from fd7c29c to a0c4f21 Compare June 4, 2022 10:06
@giordano giordano added collections Data structures holding multiple items, e.g. sets backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 labels Jun 4, 2022
@dmbates
Copy link
Member

dmbates commented Jun 4, 2022

Thanks to both @metab0t and @giordano for the fast response to #45574.

@giordano
Copy link
Contributor

giordano commented Jun 4, 2022

I did nothing! 😅

@dmbates
Copy link
Member

dmbates commented Jun 4, 2022

I did nothing! sweat_smile

You added the backport labels which will be important to me. I hope the bug fix makes it into 1.8.0-rc2 as we are teaching a workshop in mid-July and it would be good if our code gave correct answers.

@KristofferC KristofferC mentioned this pull request Jun 7, 2022
Merged
36 tasks
@KristofferC KristofferC mentioned this pull request Jul 6, 2022
Merged
15 tasks
This was referenced Jul 17, 2022
Merged
Closed
@metab0t
Copy link
Contributor Author

metab0t commented Aug 8, 2022

@KristofferC Is there any issues or blockers to merge this?

@KristofferC KristofferC mentioned this pull request Aug 17, 2022
Merged
35 tasks
@KristofferC
Copy link
Member

Sorry no, this just slipped through the cracks. Let's get it in!

@KristofferC KristofferC merged commit 5e8e0a5 into JuliaLang:master Aug 29, 2022
KristofferC pushed a commit that referenced this pull request Aug 29, 2022
@metab0t @KristofferC
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
c65611a 
…s do not overlap. (#45578)

* Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap.
Resizing of BitSet should be filled with 0 by default.

(cherry picked from commit 5e8e0a5)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 7, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@metab0t
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
172a040 
…s do not overlap. (#45578)

* Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap.
Resizing of BitSet should be filled with 0 by default.

(cherry picked from commit 5e8e0a5)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@metab0t
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
e312a36 
…s do not overlap. (#45578)

* Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap.
Resizing of BitSet should be filled with 0 by default.

(cherry picked from commit 5e8e0a5)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@metab0t
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
0a02a83 
…s do not overlap. (#45578)

* Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap.
Resizing of BitSet should be filled with 0 by default.

(cherry picked from commit 5e8e0a5)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@metab0t @staticfloat
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
134c968 
…s do not overlap. (#45578)

* Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap.
Resizing of BitSet should be filled with 0 by default.

(cherry picked from commit 5e8e0a5)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@metab0t @KristofferC
Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two range…
b21a8bb 
…s do not overlap. (#45578)

* Fix union!(s::BitSet, r::AbstractUnitRange{<:Integer}) when two ranges do not overlap.
Resizing of BitSet should be filled with 0 by default.

(cherry picked from commit 5e8e0a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 collections Data structures holding multiple items, e.g. sets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent results from repeated calls to union!(s::BitSet, r::UnitRange{Int})
4 participants
@metab0t @dmbates @giordano @KristofferC