Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPC] Remove Julia address-spaces before machine codegen #45556

Closed
wants to merge 4 commits into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jun 2, 2022

Might fix #45019

@vchuravy vchuravy added backport 1.8 Change should be backported to release-1.8 system:powerpc PowerPC labels Jun 2, 2022
@staticfloat
Copy link
Member

staticfloat commented Jun 2, 2022

Looks like progress! We're now failing on some float16 functions, I think.

https://buildkite.com/julialang/julia-buildkite/builds/571#01812575-c314-4cda-940b-8c96075ef79a/361-2629

...
float.jl
JIT session error: Symbols not found: [ __gnu_f2h_ieee, __gnu_h2f_ieee ]
Failure value returned from cantFail wrapped call
Failed to materialize symbols: { (JuliaOJIT, { julia_Float16_2934, jfptr_Float16_2935 }) }
UNREACHABLE executed at /cache/build/default-ppcbot2-0/julialang/julia-buildkite/usr/include/llvm/Support/Error.h:782!

Use Elliot's ppc64le testing branch, to avoid smashing the rest of CI
@staticfloat
Copy link
Member

Alright, I've got your PR here set to pull JuliaCI/julia-buildkite#119 as its CI configuration; so you can push things to this branch and it will only test on ppc64le-linux-gnu and x86_64-linux-gnu for now.

@vchuravy
Copy link
Member Author

vchuravy commented Jun 2, 2022

Grrml @vtjnash

JIT session error: Symbols not found: [ __gnu_f2h_ieee, __gnu_h2f_ieee ]

@vchuravy
Copy link
Member Author

vchuravy commented Jun 2, 2022

So we are still generating:

Executing precompile statements... 1438/1919
Intrinsic has incorrect argument type!
void ({} addrspace(10)*)* @llvm.ppc.cfence.p10sl_s

:/

@vchuravy
Copy link
Member Author

vchuravy commented Jun 2, 2022

Huh. Address space 0 is also not allowed?

void ({}) @llvm.ppc.cfence.p0sl_s

@giordano
Copy link
Contributor

giordano commented Jun 21, 2022

Is this PR superseded by #45755 and #45761 or it's relevant anyway?

@vchuravy vchuravy closed this Jun 21, 2022
@vchuravy
Copy link
Member Author

There is still some funkiness with that pass, but this should hopefully not be necessary

@giordano giordano deleted the vc/as_ppc branch June 21, 2022 07:23
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant generate julia-1.8.0-beta3 on powerpc (ppc64le) in LLVM generation
4 participants