fix #45440, improve the robustness of concrete-evaled callsite inlining #45451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
May 25, 2022
|
I'm not a fan of this patch, because this really shouldn't happen. Can you check if #45348 fixed this particular case? If not, we may need to fix something else. Getting |
aviatesk
added a commit
that referenced
this pull request
May 27, 2022
|
Agreed. Comfirmed #45348 fixed the reported issue on https://github.com/JuliaLang/julia/tree/release-1.8. See #45478. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed this change fixed the reported error on #44789.
Couldn't come up with a minimum reproducible test case though.