[doc] Change PDF cover font to DejaVu Sans #45290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added
docs
KristofferC
approved these changes
May 12, 2022
|
Could we backport this to 1.8? |
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2022
(cherry picked from commit c65e56f)
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the font on the PDF title/cover page (cf. #45034 (comment)) away from Helvetica to DejaVu Sans, which is actually available on the Docker image. This should fix the building of the nightly PDFs on CI. The updated cover should look like this:
@inkydragon: This is intended as a workaround until we have a better solution. For what it's worth, I noticed that even when building natively on my Ubuntu machine those fonts are still falling back to
lmr(Latin Moden Roman).I think we could definitely pick a nicer font for the cover page. However, Helvetica appears to be a proprietary font and so not easily available. If you have time, I think the best option would be to pick a nice open source font from Google Fonts, and we can bake it into the Docker image (as we do for Roboto).