Quality of life improvements for IR2OC branch #45103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 28, 2022
base/compiler/optimize.jl
Outdated
| @@ -58,10 +58,12 @@ struct InliningState{S <: Union{EdgeTracker, Nothing}, MICache, I<:AbstractInter | |||
| interp::I | |||
| end | |||
|
|
|||
| source_inferred(@nospecialize(src)) = ccall(:jl_ir_flag_inferred, Bool, (Any,), src) | |||
There was a problem hiding this comment.
is_source_inferred? Also, the src is currently required to be CodeInfo or Vector{UInt8}. Being Any unspecialized value is not legal in jl_ir_flag_inferred.
They currently affect codegen, so they need to be preserved until we decide to store the environment type somewhere else.
aviatesk
reviewed
May 2, 2022
| end | ||
|
|
||
| function Core.OpaqueClosure(ir::IRCode, env...; | ||
| nargs::Int = length(ir.argtypes)-1, |
There was a problem hiding this comment.
Shouldn't nargs be a required argument? I think length(ir.argtypes)-1 doesn't necessarily correspond to the number of actual argument as it can include entries for arbitrary slots.
There was a problem hiding this comment.
Conceptually only the ir.argtypes that correspond to the arguments have any meaning. We sometimes leave the slottypes in there for convenience, but we should probably stop doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still tracking down some issues with this branch, but in the meantime, this makes
code_llvmwork and moves the constructor into base, so that users don't have to copy the internal details everywhere. Also makes it possible to specify the return type for the IRCode variant.N.B.: PR is against jb/ircode2oc not master.