Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of donotdelete intrinsics #44793

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Change type of donotdelete intrinsics #44793

merged 1 commit into from
Mar 30, 2022

Conversation

vchuravy
Copy link
Member

Fixes #44759

@vchuravy vchuravy added the compiler:codegen Generation of LLVM IR and native code label Mar 29, 2022
@vchuravy vchuravy requested review from Keno and pchintalapudi March 29, 2022 21:34
@pchintalapudi pchintalapudi added the merge me PR is reviewed. Merge when all tests are passing label Mar 29, 2022
@vchuravy vchuravy merged commit bad450f into master Mar 30, 2022
@vchuravy vchuravy deleted the vc/donotdelete branch March 30, 2022 11:52
@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Mar 30, 2022
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Apr 3, 2022
Keno added a commit that referenced this pull request Apr 17, 2022
@Keno
Fix attributes for donotdelete intrinsic
de6ec91 
The change in #44793 changed the signature of the donotdelete intrinsic,
but didn't change the corresponding attributes, leaving a `nonnull` attribute
on a `void` return, which fails the verifier.
Keno added a commit that referenced this pull request Apr 17, 2022
@Keno
Fix attributes for donotdelete intrinsic
f188675 
The change in #44793 changed the signature of the donotdelete intrinsic,
but didn't change the corresponding attributes, leaving a `nonnull` attribute
on a `void` return, which fails the verifier.
@Keno Keno mentioned this pull request Apr 17, 2022
Merged
Keno added a commit that referenced this pull request Apr 17, 2022
@Keno
Fix attributes for donotdelete intrinsic (#45010)
ce7c858 
The change in #44793 changed the signature of the donotdelete intrinsic,
but didn't change the corresponding attributes, leaving a `nonnull` attribute
on a `void` return, which fails the verifier.
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
67 tasks
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@Keno @KristofferC
Fix attributes for donotdelete intrinsic
5073c4e 
The change in #44793 changed the signature of the donotdelete intrinsic,
but didn't change the corresponding attributes, leaving a `nonnull` attribute
on a `void` return, which fails the verifier.
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

@pchintalapudi pchintalapudi Awaiting requested review from pchintalapudi

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

donotdelete declaration differs from function call
5 participants
@vchuravy @Keno @giordano @KristofferC @pchintalapudi