ccall: add support for automatic llvmcall mangling #44697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the mangling changes by version, or is unclear, so we allow that to auto-upgrade here. Code from llvm-alloc-opt.cpp. Fix #44694
vchuravy
approved these changes
Mar 22, 2022
vtjnash
commented
Mar 22, 2022
petvana
reviewed
Mar 22, 2022
|
Thank you, seems to work well now. |
Co-authored-by: Petr Vana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the mangling changes by version, or is unclear, so we allow that to auto-upgrade here.
Code from llvm-alloc-opt.cpp.
Fix #44694
Always been something I thought it should support/verify. While we won't, in general, fix your mistakes by protecting you from the mistake of using ccall or llvmcall. I think this is something that makes sense.