port partr multiq to julia #44653
Merged
port partr multiq to julia #44653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Mar 17, 2022
vchuravy
reviewed
Mar 17, 2022
| if (multiq_insert(task, task->prio) == -1) | ||
| failed = 1; | ||
| failed = 0; | ||
| JL_PROBE_RT_TASKQ_INSERT(jl_current_task->ptls, task); |
There was a problem hiding this comment.
Losing this is disappointing :) We will need to find a way to implement this from Julia efficiently.
There was a problem hiding this comment.
Could we implement the logic of https://github.com/JuliaPerf/UProbes.jl directly in codegen?
There was a problem hiding this comment.
We could, but bpftrace would still not find the new probes. UProbes.jl works by outlining the probe to a shared library that bpftrace and co. can scan.
But this could work for code in the sysimage.
Direct translation, not necessarily fully idiomatic. In preparation for future improvements.
|
What was the performance impact of moving this? |
|
What would you recommend for a benchmark? |
|
I have something for parallel queues somewhere. Will find and post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct translation, not necessarily fully idiomatic. In preparation for
future improvements.