Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more iszero for generic linear algebra #43970

Merged
merged 1 commit into from
Jan 28, 2022
Merged

more iszero for generic linear algebra #43970

merged 1 commit into from
Jan 28, 2022

Conversation

stevengj
Copy link
Member

Changed several x == 0 calls to iszero(x) in LinearAlgebra's generic.jl.

(I noticed this when someone asked about norm for a custom number type on discourse, and I found it wouldn't work until you defined promotion with Int.)

@stevengj stevengj added the linear algebra Linear algebra label Jan 28, 2022
@oscardssmith
Copy link
Member

Most of these would be solved by #43256, but that is blocked on me finishing it.

@stevengj
Copy link
Member Author

stevengj commented Jan 28, 2022

Unrelated CI failure:

Error in testset LinearAlgebra/qr:
Error During Test at none:1
  Got exception outside of a @test
  ProcessExitedException(3)

and



FileWatching                       (10) \|    35.30 \|   3.28 \|  9.3 \|     132.33 \|  1115.29
--
  | Test                               (10) \|        started at 2022-01-28T14:35:44.424
  | From worker 15:	┌ Warning: Skipping hostname verification tests. Is `openssl` on the path?
  | From worker 15:	│   exception = IOError: could not spawn `openssl version`: no such file or directory (ENOENT)
  | From worker 15:	└ @ Main.Test2Main_LibGit2_libgit2.LibGit2Tests /cache/build/default-amdci4-6/julialang/julia-master/julia-55cd945124/share/julia/stdlib/v1.8/LibGit2/test/libgit2.jl:3104
  | From worker 15:	┌ Warning: Skipping hostname verification tests. Unable to determine a hostname which maps to the loopback address
  | From worker 15:	└ @ Main.Test2Main_LibGit2_libgit2.LibGit2Tests /cache/build/default-amdci4-6/julialang/julia-master/julia-55cd945124/share/julia/stdlib/v1.8/LibGit2/test/libgit2.jl:3134
  | LibGit2/libgit2                    (15) \|         failed at 2022-01-28T14:35:45.989
  | Error During Test at /cache/build/default-amdci4-6/julialang/julia-master/julia-55cd945124/share/julia/stdlib/v1.8/LibGit2/test/libgit2.jl:2224
  | Got exception outside of a @test
  | IOError: read: i/o error (EIO)

@stevengj stevengj merged commit 4789979 into master Jan 28, 2022
@stevengj stevengj deleted the stevengj-patch-4 branch January 28, 2022 20:06
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants