-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isdone for empty product iterators, fixes #43921 #43947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test to check this functionality. |
fredrikekre
changed the title
Fix the issue #43921
Fix isdone for empty product iterators, fixes #43921
Jan 27, 2022
fredrikekre
added
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Jan 27, 2022
This was referenced Feb 15, 2022
Merged
45 tasks
78 tasks
KristofferC
force-pushed
the
591/iteratorsfix
branch
from
November 2, 2022 12:55
06af3b0
to
3cb117d
Compare
KristofferC
added
merge me
PR is reviewed. Merge when all tests are passing
and removed
needs tests
Unit tests are required for this change
labels
Nov 2, 2022
DilumAluthge
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Nov 3, 2022
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the issue #43921